-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to openslides-status service #2960
Conversation
service.reset(); | ||
expect(actualValue).toBe(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems odd. If you don't want to change that you might instead want to test the Promise returned by the service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the reset method.
The reset method is lava code.
The reset method is not used, so I cut it and updated the tests. |
* commit '2904fb2ac5d9b8a39fff48e8ea04353077e0a3dc': (26 commits) Make user option title load - alternative (#2995) Fix safari chyron font (#2990) Move motion block recommendation text after icon (#2979) Global search style clean-up (#2977) Add tests to openslides-status service (#2960) Correcting translations (#2980) Fix line numbers at change context remainder (#2970) (#2978) Update los contribution count (#2968) Mediafile support recursive folder download (#2866) Add validators to email and default_vote_weight in some dialog (#2911) Fix a problem in the poll service (#2963) Fix version history-link (#2967) Add missing sorting for filter properies in filter list (#2953) Update way to check for agenda-item-list (#2965) Use gramatically correct email snackbar messages (#2954) Update agenda projection (#2964) Change duration of request of speakers to hours:mins (#2948) Update sort and filter at meeting switch (#2947) Fix missing star icon in motion-block (#2952) Bump crypto-js from 4.1.1 to 4.2.0 in /client (#2950) ...
I'm not sure, that the reset method is correct. It doesn't change the isStable to false.